Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] all in comfy-table #1323

Merged
merged 3 commits into from
Aug 6, 2021
Merged

[deps] all in comfy-table #1323

merged 3 commits into from
Aug 6, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Aug 6, 2021 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

remove prettytable-rs, all in comfy-table

  • prettytable-rs to comfy-table
  • ✅ -> utf-8 ☑, this will make the comfy-table align correctly
  • the format is adjusted to be more compact and consistent with the output of the fusequery

Changelog

  • Improvement

Related Issues

Related #1126 #1095 jorgecarleitao/arrow2#251

Test Plan

Unit Tests

Stateless Tests

PsiACE added 2 commits August 6, 2021 22:40
@PsiACE
[deps] change to comfy-table
97bd9a8 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
test] eliminate a warning
2438902 
Signed-off-by: Chojan Shang <[email protected]>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Hello @PsiACE, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@PsiACE PsiACE requested a review from BohuTANG August 6, 2021 14:48
@PsiACE PsiACE marked this pull request as draft August 6, 2021 14:52
@PsiACE
[fix] pretty print
36c5c61 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
Copy link
Member Author

PsiACE commented Aug 6, 2021

Old:

old-pretty-table

Now:

pretty-table

@PsiACE PsiACE marked this pull request as ready for review August 6, 2021 16:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #1323 (36c5c61) into master (dd03f12) will increase coverage by 0%.
The diff coverage is 10%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1323   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         481     481           
  Lines       27975   27967    -8     
======================================
  Hits        20252   20252           
+ Misses       7723    7715    -8
Impacted Files Coverage Δ
common/datavalues/src/series/series_debug.rs 0% <0%> (ø)
fusecli/cli/src/cmds/packages/list.rs 0% <0%> (ø)
common/datablocks/src/data_block_debug.rs 100% <100%> (ø)
common/datavalues/src/utils.rs 43% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd03f12...36c5c61. Read the comment docs.

@PsiACE PsiACE mentioned this pull request Aug 6, 2021
Closed
BohuTANG
BohuTANG approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @PsiACE

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 122deeb into databendlabs:master Aug 6, 2021
@PsiACE PsiACE deleted the comfy-table branch August 7, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PsiACE @databend-bot @codecov-commenter @BohuTANG